Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize internal error messages #3703

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Standardize internal error messages #3703

merged 1 commit into from
Nov 28, 2024
+46 −14

Conversation

turbolent
Copy link
Member

Closes #3688

Description

Add same prefix to all internal error messages

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz November 28, 2024 00:26
@turbolent turbolent self-assigned this Nov 28, 2024
@turbolent turbolent requested a review from SupunS as a code owner November 28, 2024 00:26
@github-actions GitHub Actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit d555d17
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.45455% with 24 lines in your changes missing coverage. Please review.

Project coverage is 80.17%. Comparing base (0e1b932) to head (854dd10).
Report is 133 commits behind head on master.

Files with missing lines Patch % Lines
interpreter/errors.go 58.33% 10 Missing ⚠️
errors/errors.go 54.54% 5 Missing ⚠️
runtime/storage.go 0.00% 5 Missing ⚠️
interpreter/decode.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3703      +/-   ##
==========================================
- Coverage   80.20%   80.17%   -0.03%     
==========================================
  Files         411      414       +3     
  Lines       95543    96113     +570     
==========================================
+ Hits        76629    77059     +430     
- Misses      16228    16361     +133     
- Partials     2686     2693       +7
Flag Coverage Δ
unittests 80.17% <45.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent merged commit fb30201 into master Nov 28, 2024
11 of 14 checks passed
@turbolent turbolent deleted the bastian/3688-standardize-internal-error-messages branch November 28, 2024 20:35
@BrewTestBot BrewTestBot mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@jsproz jsproz Awaiting requested review from jsproz

Assignees

@turbolent turbolent

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize internal error messages
2 participants
@turbolent @SupunS